fix: migrate to WebKitGTK 4.1 for modern Linux distributions (#9450)#10278
Open
jijinbei wants to merge 5 commits intobambulab:masterfrom
Open
fix: migrate to WebKitGTK 4.1 for modern Linux distributions (#9450)#10278jijinbei wants to merge 5 commits intobambulab:masterfrom
jijinbei wants to merge 5 commits intobambulab:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9450. Migrates Linux build from WebKitGTK 4.0 (libsoup2, EOL) to 4.1 (libsoup3), and replaces the removed
webkit_web_view_run_javascriptAPI withwebkit_web_view_evaluate_javascript(WebKit 2.40+).Changes
linux.d/debian,linux.d/fedora— requirelibwebkit2gtk-4.1-dev/webkit2gtk4.1-develunconditionally (drop the old version branches).Containerfile—libwebkit2gtk-4.0-dev→4.1-dev,libsoup2.4-dev→libsoup-3.0-dev. Baseubuntu:22.04unchanged (jammy-updates provides 4.1).src/slic3r/GUI/Widgets/WebView.cpp—externdecl +RunScript()migrated toevaluate_javascript/evaluate_javascript_finish(returnsJSCValue*, freed viag_object_unref).Compatibility
Drops Ubuntu 20.04 / Debian 11 (EOL, WebKitGTK 4.0 only). Ubuntu 22.04+ (via jammy-updates), 24.04+, Fedora 40+, and Flatpak
org.gnome.Platform//48all supported.Testing
Runtime — AppImage launched on
Ubuntu 25.10 is the bare-metal host that originally reproduced #9450. The other three are GNOME Boxes VM desktops.
CI / compile
Fork's
build_allgreen onubuntu-22.04,ubuntu-24.04,windows-latest,macos-15-intel,macos-15(arm64). Fedora 40 compile viapodmanalso succeeds with correct 4.1 / libsoup-3.0 linkage.Follow-up: Flatpak manifest
flathub/com.bambulab.BambuStudio is managed separately. To fully close #9450 for Flathub users, could a maintainer please update the manifest so the packaged runtime matches this PR (
runtime-version: '48', anylibsoup2.4/webkit2gtk-4.0module references switched to the 3.0 / 4.1 variants) and republish?